Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(programs): rkyv serialization #332

Merged
merged 7 commits into from
Jan 16, 2025
Merged

feat(programs): rkyv serialization #332

merged 7 commits into from
Jan 16, 2025

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Jan 16, 2025 •
edited
Loading

Use safe rkyv serialization.

Just serialize the HashMap corresponding to the InMemoryOracle directly, rather than using unsafe with rkyv.

Arc is platform-specific, and so attempting to serialize the Arc<Mutex<T>> with rkyv does not work well as you cross from the host platform to the zkVM platform.

@ratankaliani ratankaliani changed the title Ratan/fix rkyv branch ratan feat: rkyv cross-platform requires no arc Jan 16, 2025
@ratankaliani ratankaliani changed the title feat: rkyv cross-platform requires no arc feat(programs): rkyv cross-platform requires no arc Jan 16, 2025
@ratankaliani ratankaliani changed the title feat(programs): rkyv cross-platform requires no arc feat(programs): rkyv serialization Jan 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Metric Value
Batch Start 22,600,530
Batch End 22,600,535
Witness Generation (seconds) 47
Execution Duration (seconds) 37
Total Instruction Count 1,617,623,965
Oracle Verify Cycles 381,399,705
Derivation Cycles 825,237,458
Block Execution Cycles 291,892,678
Blob Verification Cycles 178,082,186
Total SP1 Gas 0
Number of Blocks 6
Number of Transactions 60
Ethereum Gas Used 12,197,604
Cycles per Block 269,603,994
Cycles per Transaction 26,960,399
Transactions per Block 10
Gas Used per Block 2,032,934
Gas Used per Transaction 203,293
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 1,383,961
P256 Verify Cycles 0

@ratankaliani ratankaliani merged commit 497e061 into main Jan 16, 2025
8 checks passed
@ratankaliani ratankaliani deleted the ratan/fix-rkyv-branch-ratan branch January 16, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ratankaliani